Providing a YAMLAdaptor for Psych dependency #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While updating from ActiveFedora 5.x to 6.4.0.rc4 I encountered a gotcha in that Psych was now a dependency. And with Psych comes a system dependency of libyaml. The dependency was caught on my Jenkins server (but not Travis). By providing the adaptor I am hoping to provide a bridge from YAML to Psych without an abrupt requirement. As indicated in the deprecation notice, I would envision removing the YAML adaptor.
jcoyne
added a commit
that referenced
this pull request
Jun 27, 2013
Providing a YAMLAdaptor for Psych dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating from ActiveFedora 5.x to 6.4.0.rc4 I encountered a gotcha
in that Psych was now a dependency. And with Psych comes a system
dependency of libyaml. The dependency was caught on my Jenkins server
(but not Travis).
By providing the adaptor I am hoping to provide a bridge from YAML to
Psych without an abrupt requirement. As indicated in the deprecation
notice, I would envision removing the YAML adaptor.